Skip to content

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Jan 8, 2026

Change summary

This PR adds support for a --no-default-domain flag for the Compute Deploy & Publish commands, allowing users to opt out of the automatic allocation of a domain when one isn't specified.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
 TEST_COMPUTE_DEPLOY=1 go test -v ./pkg/commands/compute -run "TestDeploy/success_with_--no-default-domain_flag_for_new_service"
 ...
 --- PASS: TestDeploy (0.70s)
    --- PASS: TestDeploy/success_with_--no-default-domain_flag_for_new_service (0.68s)
    
TEST_COMPUTE_DEPLOY=1 go test -v ./pkg/commands/compute -run "TestDeploy/success with --no-default-domain but explicit --domain provided"
...
--- PASS: TestDeploy (0.10s)
    --- PASS: TestDeploy/success_with_--no-default-domain_but_explicit_--domain_provided (0.08s)    

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

Users can now opt out of the automatic allocation of a domain when one isn't specified when deploying a new Compute service.

Additional Notes

Local testing confirms this new flag is working as expected.

@rcaril rcaril marked this pull request as ready for review January 8, 2026 20:32
@rcaril rcaril requested a review from a team as a code owner January 8, 2026 20:32
@rcaril
Copy link
Contributor Author

rcaril commented Jan 8, 2026

It looks like we needed to apply these same changes for publish. Test validation:

go test -v ./pkg/commands/compute -run "TestFlagDivergencePublish"
 === RUN   TestFlagDivergencePublish                           
     --- PASS: TestFlagDivergencePublish (0.00s)
     PASS
     ok         github.com/fastly/cli/pkg/commands/compute      0.006s

@rcaril rcaril changed the title [CDTOOL-1243] Support for --no-default-domain flag for Compute Deploy [CDTOOL-1243] Support for --no-default-domain flag for Compute Deploy & Publish Jan 8, 2026
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rcaril rcaril merged commit f0a46b9 into main Jan 12, 2026
13 checks passed
@rcaril rcaril deleted the rcaril/CDTOOL-1243-support-for-domain-skip-for-compute-deploy branch January 12, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants